RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v12]

[Volkan Yazici]

On Thu, 10 Apr 2025 13:56:55 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add `@implNote` to state that the built-in is always non-empty
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 171:
> 
>> 169:                             String message = "Server[%s] has failed! (connectionKey=%s, responseBody=%s)"
>> 170:                                     .formatted(serverId, connectionKey, responseBody);
>> 171:                             throw new RuntimeException(message, ioe);
> 
> I would recommend logging something here before throwing the exception. For instance calling `ioe.printStackTrace()`. There's not supposed to be one, and if there  is one it's not guaranteed that throwing it will ensure that it gets logged. The client might fail with some other error, or the test may timeout, and we will never know what happened.

Implemented to both log and throw in a0859c7c68614e8c3f531b1d4d9357f3f48cf5ab.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2043842705