RFR: 8325766: Review seclibs tests for cert expiry [v4]
Artur Barashev
abarashev at openjdk.org
Fri Apr 18 16:27:50 UTC 2025
On Fri, 18 Apr 2025 14:58:41 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> This PR updates the CertificateBuilder with a new method that creates a new instance with common fields (subject name, public key, serial number, validity, and key uses) filled-in. One test, IPIdentities.java, is updated to show how the method can be used to create various certificates. I attached screenshots that compare the old hard-coded certificates (left) with the new generated certificates.
>>
>> 
>> 
>> 
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>
> - expanded wildcard imports
> - Merge branch 'master' into certbuilder
> - Merge branch 'master' into certbuilder
> - reversed order of DN strings when making certificates.
> - Merge branch 'master' into certbuilder
> - Merge branch 'master' into certbuilder
> - Merge branch 'master' into certbuilder
> - Merge branch 'master' into certbuilder
> - changed boolean array initialization
> - 8325766: Review seclibs tests for cert expiry
LGTM
-------------
Marked as reviewed by abarashev (Author).
PR Review: https://git.openjdk.org/jdk/pull/23700#pullrequestreview-2778947024
More information about the net-dev
mailing list