RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v5]

Daniel Fuchs dfuchs at openjdk.org
Wed Apr 23 17:56:44 UTC 2025


On Wed, 23 Apr 2025 17:24:24 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move file URL properties out of the Proxy section, replace URI with URL
>
> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java line 242:
> 
>> 240:      static void requireFtpFallbackEnabled() throws MalformedURLException {
>> 241:         if (!FTP_FALLBACK_ENABLED) {
>> 242:             throw new MalformedURLException("Unsupported non-local file URL");
> 
> I aimed to keep this error message terse but informative, without revealing any parts of the URL spec.
> 
> A user stumbling on a rejected URL will not have a lot to work from here though..
> 
> If anyone have suggestions to improve the message, please chime in!

I have some ideas, but you may need to wait until https://git.openjdk.org/jdk/pull/23929 is integrated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24657#discussion_r2056617051


More information about the net-dev mailing list