RFR: 8355370: Include server name in HTTP test server thread names to improve diagnostics [v2]
Volkan Yazici
vyazici at openjdk.org
Thu Apr 24 07:24:37 UTC 2025
On Wed, 23 Apr 2025 14:58:45 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> 1. What is wrong with `HttpTestServer::close` calling `HttpTestServer::stop`, which is already implemented as `impl.close()` by `Http2TestServerImpl`?
>> 2. Shouldn't we better remove `implements AutoCloseable` and `close()` from `Http2TestServerImpl`?
>
> 1. If the impl is AutoCloseable then close() should call close().
> 2. I would actually prefer to make all implementations AutoCloseable, but that's not the point of this PR.
Implemented changes as requested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24822#discussion_r2057718592
More information about the net-dev
mailing list