RFR: 8355475: UNCTest should use an existing UNC path

Daniel Fuchs dfuchs at openjdk.org
Thu Apr 24 10:05:52 UTC 2025


On Thu, 24 Apr 2025 08:12:37 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this test-only PR which updates `UNCTest.java` to use a UNC path which is known to exist.
> 
> The test currently uses the file URL `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to resolve to an existing UNC path on any CI server, the test doesn't really verify what it's supposed to.
> 
> This PR changes the test to instead use the path `file://computername/C$/Windows`, which should always be available unless Administrative Shares has been disabled. We detect this case by using File::exists for the path and simply skip the test if it does not exist.
> 
> I forced this test to run in tier1 on GHA and verified that it ran successfully, without being skipped. Meaning Administrative Shares is enabled in the Windows GHA instance.
> 
> A test run in Oracle's CI verifying a successful run (without skipping) would be welcome.
> 
> This is a test only PR, `noreg-self` has been added in the JBS.

It would be good to get feedback from @bplb on this. Is the plan to integrate this change before https://git.openjdk.org/jdk/pull/24657 ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24842#issuecomment-2827052458


More information about the net-dev mailing list