RFR: 8355475: UNCTest should use an existing UNC path [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Thu Apr 24 17:42:44 UTC 2025
> Please review this test-only PR which updates `UNCTest.java` to use a UNC path which is known to exist.
>
> The test currently uses the file URL `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to resolve to an existing UNC path on any CI server, the test doesn't really verify what it intended to.
>
> This PR changes the test to instead use the path `file://computername/C$/Windows`, which should always be available unless Administrative Shares has been disabled. We detect this case by using File::exists for the path and simply skip the test if it does not exist.
>
> I forced this test to run in tier1 on GHA and verified that it ran successfully, without being skipped. Meaning Administrative Shares is enabled in the Windows GHA instance.
>
> A test run in Oracle's CI verifying a successful run (without skipping) would be welcome.
>
> This is a test only PR, `noreg-self` has been added in the JBS.
Eirik Bjørsnøs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Cleanups suggested in review
- Merge branch 'master' into unc-test-existing-path
- UNCTest should use an existing UNC path
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24842/files
- new: https://git.openjdk.org/jdk/pull/24842/files/71c31a7e..8c719220
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24842&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24842&range=00-01
Stats: 47935 lines in 1163 files changed: 38028 ins; 7139 del; 2768 mod
Patch: https://git.openjdk.org/jdk/pull/24842.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24842/head:pull/24842
PR: https://git.openjdk.org/jdk/pull/24842
More information about the net-dev
mailing list