Integrated: 8355475: UNCTest should use an existing UNC path
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Apr 25 11:19:59 UTC 2025
On Thu, 24 Apr 2025 08:12:37 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this test-only PR which updates `UNCTest.java` to use a UNC path which is known to exist.
>
> The test currently uses the file URL `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to resolve to an existing UNC path on any CI server, the test doesn't really verify what it intended to.
>
> This PR changes the test to instead use the path `file://computername/C$/Windows`, which should always be available unless Administrative Shares has been disabled. We detect this case by using File::exists for the path and simply skip the test if it does not exist.
>
> I forced this test to run in tier1 on GHA and verified that it ran successfully, without being skipped. Meaning Administrative Shares is enabled in the Windows GHA instance.
>
> A test run in Oracle's CI verifying a successful run (without skipping) would be welcome.
>
> This is a test only PR, `noreg-self` has been added in the JBS.
This pull request has now been integrated.
Changeset: e6cea402
Author: Eirik Bjørsnøs <eirbjo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e6cea4025b6743538da76f056fa831b02705f423
Stats: 34 lines in 1 file changed: 30 ins; 1 del; 3 mod
8355475: UNCTest should use an existing UNC path
Reviewed-by: dfuchs
-------------
PR: https://git.openjdk.org/jdk/pull/24842
More information about the net-dev
mailing list