RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v6]
Daniel Fuchs
dfuchs at openjdk.org
Fri Apr 25 12:30:46 UTC 2025
On Fri, 25 Apr 2025 09:44:34 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> You will still need to update `java/net/URL/OpenStream.java` to make it pass with the new changes. Possibly have two `@run`, one with `-Djdk.net.file.ftpfallback=true` and one without and adapt the test expectation based on the presence (and value) of the property.
>
>> @dfuch I went ahead and implemented this in [5b11c07](https://github.com/openjdk/jdk/commit/5b11c073190a2bc42adf2a789407bbea9e100e7c), could you have a look?
>>
>> Should be easy to revert if you are opposed to this solution for fixing the currently failing `OpenStream` test.
>
> LGTM. I wonder if we need to add a comment in OpenStream that "bad" UNC paths are tested in NonLocalFtpFallback.
> @dfuch Would you consider giving these updated tests a spin on Oracle CI to verify?
Will do. The CSR could also be moved to "Proposed".
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24657#issuecomment-2830286825
More information about the net-dev
mailing list