RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v10]

Daniel Fuchs dfuchs at openjdk.org
Fri Apr 25 17:19:08 UTC 2025


On Fri, 25 Apr 2025 17:08:09 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into disable-non-local-file-urls
>>  - Add @comment referencing testing of non-local file URLs in NonLocalFtpFallback
>>  - verifyNonLocalFileURLRejected is a better name for this test which expects the FTP fallback to be disabled
>>  - Move testing of exceptional behavior of a non-local, FTP-fallback enabled file URL from OpenStream to NonLocalFtpFallback
>>  - Add a test verifying that local file URLs such as 'file://localhost/folder/data.xml' are not affected by the FTP fallback feature being enabled
>>  - Merge branch 'master' into disable-non-local-file-urls
>>  - Fix repeated "should should"
>>  - Move file URL properties out of the Proxy section, replace URI with URL
>>  - Be explicit about explicit {@code ftp://} URIs
>>  - Document jdk.net.file.ftpfallback as a Networking Property
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/8900fd62...af73727f
>
>> I have added a Release Note as a subtask in the JBS issue, this also needs a review.
> 
> Hi Eirik, I have updated the wording of the release note at https://bugs.openjdk.org/browse/JDK-8354658 ; @AlanBateman or @Michael-Mc-Mahon may need to review my changes.

> @dfuch Would you consider giving these updated tests a spin on Oracle CI to verify?

The results came back green.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24657#issuecomment-2830988048


More information about the net-dev mailing list