RFR: 8354276: Strict HTTP header validation [v5]

Daniel Jeliński djelinski at openjdk.org
Tue Apr 29 09:49:42 UTC 2025


> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient don't fully implement the described requirements.
> 
> This PR adds the following validation:
> - pseudo-headers defined for requests are rejected in responses and push streams
> - pseudo-headers defined for responses are rejected in push promises
> - connection headers are rejected in responses and push streams
> 
> Connection headers are still accepted in push promises; that's because some popular server implementations were found to echo the request headers in push promises, and when the original request was a HTTP/1 upgrade, the push promise could contain one or more headers that were prohibited in HTTP/2 but allowed in HTTP/1.
> 
> An existing test was adapted to verify the handling of response headers. The modified test passes with this the changes in this PR, fails without them. Other tier1-3 tests continue to pass.

Daniel Jeliński has updated the pull request incrementally with five additional commits since the last revision:

 - Add test for malformed push promise headers
 - Fix orphaned header consumer
 - Make HeaderDecoder constructor take a context parameter
 - Require ValidatingHeadersConsumer.context != null
 - Move test summary next to test bug number

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24569/files
  - new: https://git.openjdk.org/jdk/pull/24569/files/4c7f30f4..085d6b5f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24569&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24569&range=03-04

  Stats: 200 lines in 5 files changed: 192 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/24569.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24569/head:pull/24569

PR: https://git.openjdk.org/jdk/pull/24569


More information about the net-dev mailing list