RFR: 8354276: Strict HTTP header validation [v4]

Daniel Jeliński djelinski at openjdk.org
Tue Apr 29 10:00:59 UTC 2025


On Mon, 28 Apr 2025 14:03:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix whitespace
>>  - Use ProtocolException for malformed headers
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java line 988:
> 
>> 986:                     // connection-level HPACK decoding state
>> 987:                     if (orphanedConsumer == null || frame.getClass() != ContinuationFrame.class) {
>> 988:                         orphanedConsumer = new ValidatingHeadersConsumer(Context.RESPONSE);
> 
> Should the context be `Context.REQUEST` if `hf instanceof PushPromiseFrame`?

Good catch. Should be fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24569#discussion_r2065969415


More information about the net-dev mailing list