RFR: 8364786: Test java/net/vthread/HttpALot.java intermittently fails - 24999 handled, expected 25000 [v2]

Daniel Fuchs dfuchs at openjdk.org
Fri Aug 8 09:05:11 UTC 2025


On Fri, 8 Aug 2025 07:38:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Alan's review - move the test definition back to before the imports
>
> test/jdk/java/net/vthread/HttpALot.java line 98:
> 
>> 96:         // go
>> 97:         server.start();
>> 98:         try (serverExecutor) {
> 
> This part looks good, as does checking that the task result is "Hello" as that adds more checking.

It would be more correct to close the server executor after server.stop() returns, to make sure the server will not try to use the executor after it's closed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26686#discussion_r2262373491


More information about the net-dev mailing list