RFR: 8208693: HttpClient: Extend the request timeout's scope to cover the response body [v16]
Jaikiran Pai
jpai at openjdk.org
Thu Dec 4 01:47:02 UTC 2025
On Wed, 3 Dec 2025 19:14:11 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Currently `HttpRequest::timeout` only applies until the response headers are received. Extend its scope to also cover the consumption of the response body.
>>
>> ### Review guidelines
>>
>> 1. Read _"the fix"_ in `MultiExchange`
>> 2. Skim through the test server *handler* in `TimeoutResponseTestSupport`
>> 3. Review first `TimeoutResponseHeaderTest`, and then `TimeoutResponseBodyTest` (Mind the multiple `@test` blocks!)
>
> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits:
>
> - Merge remote-tracking branch 'upstream/master' into respBodyTime
> - Update JavaDocs to match the spec
> - Move `cancelTimerOnResponseBodySubscriberTermination` to `ExchangeImpl`
> - Exclude disallowed timer cancellations
> - Merge remote-tracking branch 'upstream/master' into respBodyTime
> - Cancel timer right away if response body is not permitted
> - Configure timeout for the `WebSocketTest`
> - Use `var`
> - Clarify WebSocket behaviour and test it
> - Verify no lingering response timers
> - ... and 32 more: https://git.openjdk.org/jdk/compare/7278d2e8...5f99578a
The updated text looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27469#pullrequestreview-3537553541
More information about the net-dev
mailing list