RFR: 8372746: Some httpserver files could benefit from some formatting cleanup [v2]

Daisuke Yamazaki dyama at openjdk.org
Fri Dec 5 10:32:16 UTC 2025


On Fri, 5 Dec 2025 01:39:52 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> Daisuke Yamazaki has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix wrong indentation in package-info.java
>
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/package-info.java line 123:
> 
>> 121:         public void configure (HttpsParameters params) {
>> 122: 
>> 123:         // get the remote address if needed
> 
> Always hard to tell, but I _think_ the indentation of this whole block (the body of the `configure` method) is still off - all the lines 123-136 should be indented 4 more space?

Thanks for your reviewing.
I totally missed that.
I shifted the whole thing 4 spaces so it's consistent now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28660#discussion_r2592176440


More information about the net-dev mailing list