RFR: 8372746: Some httpserver files could benefit from some formatting cleanup [v2]

Jaikiran Pai jpai at openjdk.org
Mon Dec 8 07:12:59 UTC 2025


On Fri, 5 Dec 2025 10:32:14 GMT, Daisuke Yamazaki <dyama at openjdk.org> wrote:

>> Hello mainteners,
>> 
>> I cleaned up inconsistent spacing across the httpserver codebase.  
>> 
>> 1. Removed extra spaces before parentheses in function and constructor declarations to make them consistent.
>> 2. Applied the same rule to function and constructor calls.
>> 3. Normalised other spacing based on the majority style already used in the codebase.
>> 4. Left spots untouched where keeping the spacing improves readability.
>> 
>> **This PR only adds or removes spaces. No functional changes.**
>> 
>> If you think it would have been better to update only the documentation part and leave the logic untouched, please let me know.
>> I split the commits, so I can easily revert the one that touches the logic.
>
> Daisuke Yamazaki has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix wrong indentation in package-info.java

src/jdk.httpserver/share/classes/sun/net/httpserver/LeftOverInputStream.java line 82:

> 80:     }
> 81: 
> 82:     protected abstract int readImpl(byte[]b, int off, int len) throws IOException;

Here too, please add a space between `byte[]` and `b`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28660#discussion_r2597293226


More information about the net-dev mailing list