RFR: 8371903: HttpClient: improve handling of HTTP/2 GOAWAY frames with error code [v7]
Jaikiran Pai
jpai at openjdk.org
Thu Dec 11 12:41:58 UTC 2025
On Thu, 11 Dec 2025 12:33:22 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> EunHyunsu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8371903: Use Utils.adjustTimeout() in GoAwayWithErrorTest
>
> test/jdk/java/net/httpclient/http2/GoAwayWithErrorTest.java line 124:
>
>> 122:
>> 123: CompletableFuture.allOf(first, second, third)
>> 124: .orTimeout(Utils.adjustTimeout(20), TimeUnit.SECONDS)
>
> Similar to the review comment above, we shouldn't use any timeout here and instead should just wait for the requests to complete.
On second look, is this entire `allOf(...).join()` even needed? From what I see in the next lines, the test iterates over the CompletableFuture(s) of the requests and join()s on each request waiting for it to complete.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28632#discussion_r2610435450
More information about the net-dev
mailing list