RFR: 8371903: HttpClient: improve handling of HTTP/2 GOAWAY frames with error code [v7]

[Jaikiran Pai]

On Sat, 13 Dec 2025 04:38:25 GMT, EunHyunsu <duke at openjdk.org> wrote:

>> EunHyunsu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8371903: Use Utils.adjustTimeout() in GoAwayWithErrorTest
>
> @jaikiran Thank you for the detailed review! I've addressed all your feedback:
> 
> 1. **Http2Connection.java**: Removed the `else` block so `close(cause)` → `doTerminate()` handles processed streams. This ensures connection closure cause and stream termination cause are consistent.
> 
> 2. **GoAwayWithErrorTest.java**:
> - Using `URIBuilder` with server's actual address instead of "localhost"
> - Removed timeout from `goAwaySentLatch.await()`
> - Removed entire `allOf().orTimeout().join()` block
> - Replaced success counting with direct `assertEquals(200, response.statusCode())`

Thank you @ehs208 for these updates. The changes look good to me. I'll run the latest changes in our CI to make sure this continues to pass.

On a related note, have you run tier2 locally with these changes? The GitHub actions job only run tier1 and networking tests aren't covered in that. It would be good to run tier2 on your local setup too - that way any future contributions in this area can be tested locally to verify that changes don't break unexpected existing tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28632#issuecomment-3655560537