RFR: 8373409: java/net/httpclient/http3/H3ErrorHandlingTest.java failed due to deadlock
Daniel Jeliński
djelinski at openjdk.org
Wed Dec 17 07:53:05 UTC 2025
On Mon, 15 Dec 2025 09:34:44 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> I checked all other uses of `CHM.compute` in the `java.net.http` module; most of them are trivially correct. The ones in `AltServiceRegistry` are not trivial, and might need to be replaced with something easier to reason about. I'll look into that.
>>
>> EDIT - checked the `AltServiceRegistry`; `compute` is only used on a (non-concurrent) HashMap while holding a lock, and the lambdas only use functions internal to the registry. This should be fine as well.
>
>> I checked all other uses of `CHM.compute` in the `java.net.http` module; most of them are trivially correct. The ones in `AltServiceRegistry` are not trivial, and might need to be replaced with something easier to reason about. I'll look into that.
>>
>> EDIT - checked the `AltServiceRegistry`; `compute` is only used on a (non-concurrent) HashMap while holding a lock, and the lambdas only use functions internal to the registry. This should be fine as well.
>
> Thanks for checking the other uses of `CHM.compute` @djelinski !
Thanks @dfuch for the review!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28788#issuecomment-3664091377
More information about the net-dev
mailing list