RFR: 8373677: Clear text HttpServer connection could fail fast if receiving SSL ClientHello [v3]

Daniel Fuchs dfuchs at openjdk.org
Wed Dec 17 11:51:08 UTC 2025


On Wed, 17 Dec 2025 11:18:28 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/jdk/com/sun/net/httpserver/ClearTextServerSSL.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update src/jdk.httpserver/share/classes/sun/net/httpserver/Request.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java line 743:
> 
>> 741:                 } catch (ProtocolException pe) {
>> 742:                     logger.log(Level.DEBUG, pe.toString());
>> 743:                     logger.log(Level.DEBUG, "Bad first char in request line: closing");
> 
> Could we perhaps combine these 2 lines into one:
> 
> 
> logger.log(Level.DEBUG, "closing due to: " + pe.toString());

done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28827#discussion_r2626734549


More information about the net-dev mailing list