RFR: 8373869: Refactor java/net/httpclient/ThrowingPushPromises*.java tests to use JUnit5
Jaikiran Pai
jpai at openjdk.org
Thu Dec 18 09:21:33 UTC 2025
On Wed, 17 Dec 2025 12:34:47 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
> These test used to use the testng IContextTest API to stop tests after the first failure.
> Usage of IContextTest has been replaced with a TestWatcher that records the first failure and uses Assumptions to prevent further test execution.
>
> This is similar to what was done for the `java/net/httpclient/ThrowingPublishers*.java` tests in https://github.com/openjdk/jdk/pull/28846 and for `java/net/httpclient/ThrowingSubscribers*.java` in https://github.com/openjdk/jdk/pull/28865
This looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28868#pullrequestreview-3591630533
More information about the net-dev
mailing list