RFR: 8373866: Refactor java/net/httpclient/ThrowingSubscribers*.java tests to use JUnit5 [v2]

Jaikiran Pai jpai at openjdk.org
Thu Dec 18 09:28:55 UTC 2025


On Wed, 17 Dec 2025 12:04:33 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> These test used to use the testng IContextTest API to stop tests after the first failure.
>> Usage of IContextTest has been replaced with a TestWatcher that records the first failure and uses Assumptions to prevent further test execution.
>> 
>> This is similar to what was done for the `java/net/httpclient/ThrowingPublishers*.java` tests in https://github.com/openjdk/jdk/pull/28846
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   small abstract class cleanup

Looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28865#pullrequestreview-3591663069


More information about the net-dev mailing list