RFR: 8373893: Refactor networking http server tests to use JUnit [v5]
Michael McMahon
michaelm at openjdk.org
Wed Dec 31 09:00:35 UTC 2025
On Wed, 31 Dec 2025 06:27:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into JUNIT-8373893
>> - removed remaining PER_CLASS annotations
>> - review update
>> - Apply suggestions from code review
>>
>> Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
>> - test update
>> - copyright update
>> - output from tool modified for a few files
>
> test/jdk/com/sun/net/httpserver/HeadersTest.java line 162:
>
>> 160: }
>> 161:
>> 162: public static Object[][] responseHeaders() {
>
> I assume this could be return `Stream<Arguments>` instead of `Object[][]`.
That pattern is very common across many of these tests (62 sites). I can change them, but I wonder how much improvement like this is within the scope of this conversion effort.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2655036873
More information about the net-dev
mailing list