RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

Daniel Fuchs dfuchs at openjdk.org
Wed Feb 5 18:15:14 UTC 2025


On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Update and clarify the sample code.
>> 
>> Docs only, no additional testing other than verifying javadoc is correctly output.
>
> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Codereview Comments

I had to convince myself (using jshell) that `rfc8701Grease8A.getBytes("ISO_8859_1")` would return the correct result - but I see that's OK, so this looks good to me. Maybe wait for a review from someone from security-libs before integrating.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23379#pullrequestreview-2596603327


More information about the net-dev mailing list