RFR: 8349702: jdk.internal.net.http.Http2Connection::putStream needs to provide cause while cancelling stream [v2]
Daniel Fuchs
dfuchs at openjdk.org
Tue Feb 11 16:01:16 UTC 2025
On Tue, 11 Feb 2025 11:46:44 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in the ticket for details on the issue. `tier1,2` results are attached to the ticket too.
>
> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>
> - Add current issue to the `@bug` list in `AsyncExecutorShutdown`
> - Wrap the cause in an `IOException`
>
> This is okay, because `AsyncExecutorShutdown` walks
> the causal chain while searching for a certain
> exception footprint.
Thanks Volkan! LGTM.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23540#pullrequestreview-2609215939
More information about the net-dev
mailing list