RFR: 8349813: Test behavior of limiting() on RS operators throwing exceptions [v2]

Volkan Yazici vyazici at openjdk.org
Wed Feb 12 09:16:51 UTC 2025


On Tue, 11 Feb 2025 12:15:11 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Max. the `limiting` capacity
>>  - Merge remote-tracking branch 'upstream/master' into ThrowingLimitingTest
>>  - Verify `limiting()` behavior on misbehaving RS operators
>
> test/jdk/java/net/httpclient/ThrowingSubscribersAsLimiting.java line 63:
> 
>> 61:                         HttpResponse.BodyHandlers.ofLines(),
>> 62:                         // A big enough capacity to allow a minimal response with basic headers and such
>> 63:                         1024);
> 
> Look good to me. Will 1024 be enough? We do not want the capacity to be reached here, so we might as well use Integer.MAX_VALUE or Long.MAX_VALUE?

I wanted to use something else than the theoretical limit, but that is fine too. Replaced it with `Long.MAX_VALUE` in f8d11a2fca95c6ed234285b932ff40fb98426126.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23559#discussion_r1952258634


More information about the net-dev mailing list