RFR: 8350451: HttpClient should not wait until the request body has been fully sent before reading the response headers [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed Feb 26 11:55:58 UTC 2025
On Wed, 26 Feb 2025 09:33:44 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review feedback
>
> test/jdk/java/net/httpclient/PostFromGetTest.java line 451:
>
>> 449: httpTestServer = HttpTestServer.create(HTTP_1_1, null, serverExecutor);
>> 450: httpTestServer.addHandler(h1_chunkHandler, "/http1/x/");
>> 451: httpURI = "http://" + httpTestServer.serverAuthority() + "/http1/x/";
>
> There has been occasions where a request got incorrectly served by a parallel running test. Last time we've salted the paths:
>
> https://github.com/openjdk/jdk/blob/f529bf712d8946584999dfc98abea60c22c97167/test/jdk/java/net/httpclient/PlainProxyConnectionTest.java#L77
>
> We can consider doing the same here too.
replaced `x` with `PostFromGet`. That should be enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23716#discussion_r1971452061
More information about the net-dev
mailing list