RFR: 8347348: Clarify that the HTTP server in jdk.httpserver module is not a full featured server
Brian Burkhalter
bpb at openjdk.org
Thu Jan 9 15:38:36 UTC 2025
On Thu, 9 Jan 2025 13:06:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this doc-only change which clarifies the purpose of the HTTP server that's provided in the JDK's `jdk.httpserver` module? This should help avoid any confusion on the purpose of the server.
src/jdk.httpserver/share/classes/module-info.java line 30:
> 28: * for running a minimal HTTP server.
> 29: *
> 30: * <p>The API, SPI and the server implementation in this module is intended
1. Add a comma after SPI. ( I had to look up that acronym).
2. Change "is intended" to "are intended."
src/jdk.httpserver/share/classes/module-info.java line 32:
> 30: * <p>The API, SPI and the server implementation in this module is intended
> 31: * for simple usages like local testing, development, and debugging.
> 32: * Accordingly, the design and implementation of the server is explicitly
Change "is explicitly" to "are explicitly"?
src/jdk.httpserver/share/classes/module-info.java line 33:
> 31: * for simple usages like local testing, development, and debugging.
> 32: * Accordingly, the design and implementation of the server is explicitly
> 33: * minimal so as to avoid confusion with a full-featured and high
Replace "and" with a comma?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1909030875
PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1909032183
PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1909032901
More information about the net-dev
mailing list