RFR: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory [v2]

[Alan Bateman]

On Mon, 13 Jan 2025 15:45:07 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Alan's review - update skip reason
>
> test/jdk/java/net/DatagramSocket/InterruptibleDatagramSocket.java line 104:
> 
>> 102:             throw new jtreg.SkippedException(
>> 103:                     "skipping test execution - main thread is a virtual thread");
>> 104:         }
> 
> I wonder - would it work instead to replace:
> 
> test(s, false);
> 
> with
> 
> test(s, Thread.currentThread().isVirtual());
> 
> 
> I am not sure it would work - because the exception that gets thrown could be different... But this would be a way to test both the main-is-virtual and main-is-not-virtual cases.

There was some discussion about this in the JBS issue. BlockingSocketOps.testDatagramSocketReceiveInterrupt tests the scenario for virtual threads so it would be a duplicate test. It doesn't matter, skipping or changing it is fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23074#discussion_r1913658986