RFR: 8328919: Add BodyHandlers / BodySubscribers methods to handle excessive server input [v5]

Jaikiran Pai jpai at openjdk.org
Wed Jan 15 14:03:42 UTC 2025


On Wed, 15 Jan 2025 10:50:55 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> Adds `limiting()` factory methods to `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input in `HttpClient`. I would appreciate your input whether `discardExcess` should be kept or dropped. I plan to file a CSR once there is an agreement on the PR.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove concurrency measures (methods are accessed serially due to the Reactive Streams spec)

src/java.net.http/share/classes/java/net/http/HttpResponse.java line 758:

> 756:          * <p>
> 757:          * If the number of bytes received exceeds the maximum number of bytes
> 758:          * desired as indicated by the given {@code capacity},

Should we consider simplifying this sentence to "If the number of bytes received exceeds the given {@code capacity}, ..."?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1916701366


More information about the net-dev mailing list