RFR: 8344943: Mark not subclassable classes final in java.base exported classes

[Eirik Bjørsnøs]

On Tue, 26 Nov 2024 20:08:28 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/InterfaceAddress.java line 45:
>> 
>>> 43: 
>>> 44:     /*
>>> 45:      * Package private constructor. Can't be built directly, instances are
>> 
>> The comment is outdated.  This constructor is actually called via JNI like `(*env)->NewObject(env, ni_ibcls, ni_ibctrID)` in `NetworkInterface.c`.  I think we need to consult a network engineer to decide what is the best way to comment on this constructor.
>
> A pleasant surprise - since we aren't modifying constructor modifiers, we can put these intricacies on hold.  Thanks for limiting the scope of this patch.

Indeed, this makes this PR much simpler.

I have filed separate JBS issues to track these constructor updates:

https://bugs.openjdk.org/browse/JDK-8345074 for`InterfaceAddress` 
https://bugs.openjdk.org/browse/JDK-8345075 for `ModuleDescriptor`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22389#discussion_r1859196447