RFR: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

Jaikiran Pai jpai at openjdk.org
Tue Jan 21 15:33:48 UTC 2025


On Fri, 17 Jan 2025 15:38:16 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> The jdk/java/net/httpclient/offline/FixedResponseHttpClient.java test class makes unreasonable assumptions on BodyPublisher implementation. There's no guarantee that all buffers will be available until the subscriber is completed. 
> The fix is to way for completion before getting the consumed buffers.

This looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23176#pullrequestreview-2564985943


More information about the net-dev mailing list