Integrated: 8345249: Apply some conservative cleanups in FileURLConnection

Eirik Bjørsnøs eirbjo at openjdk.org
Fri Jan 24 13:03:52 UTC 2025


On Fri, 29 Nov 2024 13:33:37 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this PR which applies various cleanups to `sun.net.www.protocol.file.FileURLConnection`.
> 
> This class is known to be an _old, intricate, and hard to maintain piece of code._  However, there are some relatively straightforward and safe cleanups possible which improve readability and makes it easier to reason about what's going on in this class.
> 
> In this PR, I have chosen to make each individual small change a separate commit. This to assist review of each individual change, which can otherwise disappear a bit when reviewing the PR as a whole. 
> 
> A detailed listing of each commit follows in a separate comment.
> 
> This is a pure cleanup PR, no tests are added or updated in this PR.

This pull request has now been integrated.

Changeset: 9768f60a
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9768f60a945db277ded5e37ecba9ec34421d9968
Stats:     38 lines in 1 file changed: 2 ins; 13 del; 23 mod

8345249: Apply some conservative cleanups in FileURLConnection

Reviewed-by: jpai, djelinski

-------------

PR: https://git.openjdk.org/jdk/pull/22459


More information about the net-dev mailing list