RFR: 8342807: Update links in java.base to use https:// [v5]
Joachim Kern
jkern at openjdk.org
Mon Jan 27 08:45:47 UTC 2025
On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> Please review this cleanup PR which updates a total of 12 links to external documentation or references in `java.base` to use https instead of plain text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>>
>> This is a documentaton-only cleanup. No tests are added or updated. `noreg-cleanup` added in the JBS. All updated links have been verified to resolve and to show the expected content.
>>
>> There are two files here with non-Oracle copyright headers, not quite sure how to update those? (`java_md_aix.h` and `xss-common-qsort.h`).
>>
>> Changes beyond the obvious are as follows:
>>
>> `linux/native/libsimdsort/xss-common-qsort.h`:
>> The current link uses a non-default port number. Changed to using the default port number. Reported and fixed upstream as intel/x86-simd-sort#170
>>
>> `share/man/keytool.md`:
>> www.oracle.com redirects this from `/technetwork/java/javase/javasecarootcertsprogram-1876540.html` to `/java/technologies/javase/carootcertsprogram.html`. Using the new URL here.
>>
>> `unix/classes/sun/net/PortConfig.java`
>> The current link no longer resolves. As a replacement, I suggest https://www.ibm.com/support/pages/node/886227 which answers a support question regarding ephemeral ports.
>>
>> `unix/native/libjava/*`,
>> Links redirect from "www.opengroup.org" to "pubs.opengroup.org". Using this new host in the URLs
>>
>> `unix/native/libjava/ProcessImpl_md.c`
>> A link to an "unofficial" document on pasc.org now requires authentication. This document is probably outdated and the link is removed.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright headers for 2025 for Oracle files
Marked as reviewed by jkern (Committer).
src/java.base/unix/classes/sun/net/PortConfig.java line 57:
> 55: case AIX:
> 56: // The ephemeral port is OS version dependent on AIX:
> 57: // https://www.ibm.com/support/pages/node/886227
LGTM
-------------
PR Review: https://git.openjdk.org/jdk/pull/21633#pullrequestreview-2574814301
PR Review Comment: https://git.openjdk.org/jdk/pull/21633#discussion_r1930152051
More information about the net-dev
mailing list