RFR: 8352502: Response message is null if expect 100 assertion fails with non 100 [v2]
Daniel Fuchs
dfuchs at openjdk.org
Tue Jul 8 14:42:42 UTC 2025
On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:
>> Currently if a request has set Expect-Continue and receives a non 100 response the `responseMessage` wouldn't be set.
>>
>> This PR sets `responseMessage`, it also updates `getResponseMessage` to check if the message has already been set. This should match the way that `responseCode` is currently handled.
>>
>> I also added a test to cover some possible responses.
>
> Darragh Clarke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - removed unneeded library
> - more cleanup
> - moved test, implemented feedback
> - merged master into branch
> - implementing comments
> - Response Message could be null
I believe this looks good. Please make sure the test is stable over all supported platforms before integrating.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25999#pullrequestreview-2997964242
More information about the net-dev
mailing list