RFR: 8352502: Response message is null if expect 100 assertion fails with non 100 [v2]

Darragh Clarke dclarke at openjdk.org
Thu Jul 10 13:28:28 UTC 2025


On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

>> Currently if a request has set Expect-Continue and receives a non 100 response the `responseMessage` wouldn't be set.
>> 
>> This PR sets `responseMessage`, it also updates `getResponseMessage` to check if the message has already been set. This should match the way that `responseCode` is currently handled.
>> 
>> I also added a test to cover some possible responses.
>
> Darragh Clarke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - removed unneeded library
>  - more cleanup
>  - moved test, implemented feedback
>  - merged master into branch
>  - implementing comments
>  - Response Message could be null

I added salting to the test and some handling on the serverSocket to check for it.
I may have overcomplicated the rewrite to include that change so feel free to request more changes

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25999#issuecomment-3057455458


More information about the net-dev mailing list