Integrated: 8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

Jaikiran Pai jpai at openjdk.org
Sun Jul 27 06:47:56 UTC 2025


On Sat, 26 Jul 2025 09:04:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which removes the use of `Thread.stop()` from the test? This addresses https://bugs.openjdk.org/browse/JDK-8360981.
> 
> The use of `Thread.stop()` `test/jdk/java/net/Socket/DeadlockTest.java` isn't necessary for what this test is currently testing. The commit in this PR removes that call and instead wait for the `Thread` to complete execution, by calling `Thread.join()` without any timeouts. If a genuine deadlock does happen, then the test will time out (on the `Thread.join()` call) and the jtreg infrastructure should then help get hold of the necessary thread dumps to identify the cause of the deadlock.
> 
> The test continues to pass with this change.

This pull request has now been integrated.

Changeset: 3263361a
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3263361a28c7e8c02734cb94bc9576e9f3ba5b50
Stats:     22 lines in 1 file changed: 7 ins; 7 del; 8 mod

8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/26490


More information about the net-dev mailing list