RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v5]
Volkan Yazici
vyazici at openjdk.org
Wed Jul 30 17:59:00 UTC 2025
On Wed, 30 Jul 2025 15:30:07 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply review feedback for `FileChannelPublisherTest`
>
> test/jdk/java/net/httpclient/FileChannelPublisherTest.java line 27:
>
>> 25: * @test
>> 26: * @summary Verifies `HttpRequest.BodyPublishers::ofFileChannel`
>> 27: * @library /test/lib
>
> Nit: Could you please add a `@bug` with id here?
@myankelev, AFAIK, `@bug` is used to refer to _bugs_, not _features_. Tests in `test/jdk/java/net` adhere to this practice too. Since `FCPT` does not address a bug (at least, not yet :crossed_fingers:), I intentionally omitted the `@bug` tag.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26155#discussion_r2243472267
More information about the net-dev
mailing list