RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher [v3]
Daniel Fuchs
dfuchs at openjdk.org
Fri Jun 6 11:15:54 UTC 2025
On Fri, 6 Jun 2025 11:07:34 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Simplifies content streaming for `HttpRequest.BodyPublishers::ofFile(Path)`, which delegates to `RequestPublishers.FilePublisher::create(Path)`. This effectively replaces all usages of `FileInputStream::new` in `HttpClient` with `Files::newInputStream(Path)`. See the JBS ticket description for the full story.
>>
>> Also removing certain test files which were rendered redundant after `SecurityManager` removal. We do this in this PR, since tests were added due to touched lines.
>>
>> `tier1,2` results on b5f3c8dc6f4 are attached to the ticket.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Update tests
LGTM. Maybe wait for comments from @jaikiran before integrating
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25662#pullrequestreview-2904613238
More information about the net-dev
mailing list