RFR: 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Jun 9 11:43:04 UTC 2025
On Mon, 9 Jun 2025 09:59:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Daniel's suggestion
>
> src/java.base/share/classes/java/net/Socket.java line 625:
>
>> 623: *
>> 624: * @apiNote Establishing a TCP/IP connection is subject to connection timeout settings
>> 625: * in the operating system. The typical timeout is 60 seconds. If the operating system
>
> Suggestion:
>
> * in the operating system. The typical operating system timeout is 60 seconds. If the operating system
>
>
> I would suggest repeating "operating system timeout" here too, to remove confusion with the simple API `timeout` which also appears later in this paragraph.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25690#discussion_r2135566991
More information about the net-dev
mailing list