RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher [v4]
Jaikiran Pai
jpai at openjdk.org
Wed Jun 11 11:56:36 UTC 2025
On Wed, 11 Jun 2025 10:49:48 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Simplifies content streaming for `HttpRequest.BodyPublishers::ofFile(Path)`, which delegates to `RequestPublishers.FilePublisher::create(Path)`. This effectively replaces all usages of `FileInputStream::new` in `HttpClient` with `Files::newInputStream(Path)`. See the JBS ticket description for the full story.
>>
>> Also removing certain test files which were rendered redundant after `SecurityManager` removal. We do this in this PR, since tests were added due to touched lines.
>>
>> `tier1,2` results on b5f3c8dc6f4 are attached to the ticket.
>
> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into requestPublishersDefaultFs
> - Improve comments
> - Update tests
> - Add back removed SM tests
> - Remove redundant tests
> - Remove redundant OIO usage in `RequestPublishers`
Thank you for the updates Volkan. This looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25662#pullrequestreview-2916818453
More information about the net-dev
mailing list