RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher [v5]

[Volkan Yazici]

On Thu, 12 Jun 2025 08:34:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix `FilePublisherTest`
>
> test/jdk/java/net/httpclient/FilePublisher/FilePublisherTest.java line 168:
> 
>> 166:         try (FileSystem fs = newZipFs(zipPath)) {
>> 167:             Path fileInZip = zipFsFile(fs);
>> 168:             Files.deleteIfExists(fileInZip);
> 
> Now that I look at this, perhaps we should just change these 2 lines:
> 
> Path fileInZip = zipFsFile(fs);
> Files.deleteIfExists(fileInZip);
> 
>  to:
> 
> 
> Path fileInZip = fs.getPath("non-existent.txt");
> 
> The call to `zipFsFile(...)` creates a ZIP entry within the ZIP and we then delete it immediately here with the deleteIfExists(...) call. At least for this new test, this creation followed by the deletion isn't necessary.

Simplified as suggested in 1eadf2dc4b8.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25662#discussion_r2142155769