RFR: 8351983: HttpCookie Parser Incorrectly Handles Cookies with Expires Attribute [v5]

Michael McMahon michaelm at openjdk.org
Thu Jun 12 12:48:33 UTC 2025


On Thu, 5 Jun 2025 05:32:34 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test update
>
> test/jdk/java/net/HttpCookie/MaxAgeExpires.java line 63:
> 
>> 61:     }
>> 62: 
>> 63:     static Test[] tests = new Test[] {
> 
> *Tip:* JUnit `@ParameterizedTest @CsvSource` can save us some boilerplate here.

I've updated the implementation to allow for testing with fixed cookie creation times and expiry check times. And then added some tests of this. If we're okay with it, I'd like to work on the CSR at this point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25636#discussion_r2142646125


More information about the net-dev mailing list