RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher [v6]
Volkan Yazici
vyazici at openjdk.org
Thu Jun 12 17:13:36 UTC 2025
On Thu, 12 Jun 2025 14:42:27 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Simplify `FilePublisherTest`
>
> The person who wrote the test was probably concerned that `fs.getPath("non-existent.txt");` could throw if passed a non-existing path. Looking at the API documentation that doesn't seem a valid concern. The only exception documented is `InvalidPathException` - so we should be good
@dfuch @jaikiran Thank you so much for reviews, much appreciated. :bowing_man:
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25662#issuecomment-2967615342
More information about the net-dev
mailing list