RFR: 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout [v4]
Daniel Fuchs
dfuchs at openjdk.org
Mon Jun 16 11:41:30 UTC 2025
On Sun, 15 Jun 2025 04:41:22 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this doc-only change which proposes to add a `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)` method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in that issue, users can find it surprising that when the `Socket.connect(...)` method is called with a `timeout` value, then if that timeout value happens to be greater than the connect timeout that operating systems typically impose, then a `IOException` gets thrown instead of the `SocketTimeoutException`. The change in this PR proposes to add a `@apiNote` which explains this current behaviour.
>>
>> If this requires a CSR, I'll open one once we settle on the proposed text.
>
> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>
> - Mark's suggestion - use "connect timeout" instead of "connection timeout"
> - Daniel's suggestion for the text
Marked as reviewed by dfuchs (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25690#pullrequestreview-2931736198
More information about the net-dev
mailing list