RFR: 8359223: HttpClient: Remove leftovers from the SecurityManager cleanup [v2]
p-nima
duke at openjdk.org
Mon Jun 16 14:10:29 UTC 2025
On Fri, 13 Jun 2025 07:55:17 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Removes following files added in [JDK-8235459](https://bugs.openjdk.org/browse/JDK-8235459) and are forgotten to be removed during the `SecurityManager`-removal ([JDK-8344228](https://bugs.openjdk.org/browse/JDK-8344228)):
>>
>>
>> test/jdk/java/net/httpclient/FilePublisher/FilePublisherPermsTest.java
>> test/jdk/java/net/httpclient/FilePublisher/SecureZipFSProvider.java
>>
>>
>> Subsequently moved `test/jdk/java/net/httpclient/FilePublisher/FilePublisherTest.java`, the only file remained in that folder, one level up.
>
> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Move `FilePublisherTest` one level up
> - Merge remote-tracking branch 'upstream/master' into hcSmFollowUp
> - Remove leftover tests from the SecurityManager cleanup
Please correct me if I am wrong, as per my understanding it is essential to test a custom provider (in this case SecureZipFSProvider), as the path would be dependent on the provider, and is not related to the security manager - [docs](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java#L280)
-------------
Changes requested by p-nima at github.com (no known OpenJDK username).
PR Review: https://git.openjdk.org/jdk/pull/25747#pullrequestreview-2932294202
More information about the net-dev
mailing list