RFR: 8332623: Remove setTTL()/getTTL() methods from DatagramSocketImpl/MulticastSocket and MulticastSocket.send(DatagramPacket, byte) [v3]

Jaikiran Pai jpai at openjdk.org
Tue Jun 17 08:34:37 UTC 2025


On Wed, 11 Jun 2025 12:07:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to remove the deprecated-for-removal methods from `MulticastSocket` and `DatagramSocketImpl`? 
>> 
>> The following methods on `java.net.MulticastSocket` and `java.net.DatagramSocketImpl`:
>> 
>> 
>> public void setTTL(byte ttl) throws IOException
>> public byte getTTL() throws IOException
>> 
>> 
>> and this other one on `MulticastSocket`:
>> 
>> 
>> public void send(DatagramPacket p, byte ttl) throws IOException 
>> 
>> 
>> have been deprecated for removal since Java 23, through https://bugs.openjdk.org/browse/JDK-8332181. Even before that they have been deprecated since Java 1.2 and Java 1.4.
>> 
>> The commit in this PR removes them completely. This PR also removes some tests that were specifically testing the `setTTL()/getTTL()/send(DatagramPacket, byte)` methods. A few other tests have been adjusted to use the alternate `getTimeToLive()/setTimeToLive()` methods where appropriate.
>> 
>> Existing tests in tier1, tier2 and tier3 continue to pass with these changes.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Daniel's review - continue to test MulticastSocket in SendCheck

The CSR has been approved and tier1, tier2 and tier3 tests continue to pass with this change. Thank you Alan and Daniel for the reviews. I'll go ahead and integrate this now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25744#issuecomment-2979441579


More information about the net-dev mailing list