RFR: 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout [v5]
Jaikiran Pai
jpai at openjdk.org
Wed Jun 18 02:09:38 UTC 2025
On Tue, 17 Jun 2025 08:40:10 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this doc-only change which proposes to add a `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)` method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in that issue, users can find it surprising that when the `Socket.connect(...)` method is called with a `timeout` value, then if that timeout value happens to be greater than the connect timeout that operating systems typically impose, then a `IOException` gets thrown instead of the `SocketTimeoutException`. The change in this PR proposes to add a `@apiNote` which explains this current behaviour.
>>
>> If this requires a CSR, I'll open one once we settle on the proposed text.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> Alan's suggestion
The CSR has been approved. Thank you all for the inputs and reviews. I'll go ahead with the integration.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25690#issuecomment-2982365926
More information about the net-dev
mailing list