Withdrawn: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress
Eirik Bjørsnøs
eirbjo at openjdk.org
Thu Jun 19 09:04:36 UTC 2025
On Sat, 5 Apr 2025 10:23:33 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please help review this PR which improves `HttpServer::stop` termination timing to better fit user expectations.
>
> This PR:
>
> * Makes `ServerImpl::stop` continue without delay when there are no active exchanges during shutdown
> * Attempts to interrupt the dispatcher thread before joining it, giving long-living interruptible exchanges a chance to finish early
> * Adds testing for boundary conditions with or without an active exchange, delay occurring before exhange completes and exchange completing before delay.
>
> Additionally, `ServerImpl::stop` is updated to use `System::nanotime` instead of `System::currentTimeMillis` when calculating wait times.
>
> The test relies on timing to assert the order of events. Not perfect, but it seems to work.
>
> (This part of the code base is rather new to me. A bit of hand-holding should be expected when reviewing this PR)
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.org/jdk/pull/24467
More information about the net-dev
mailing list