RFR: 8359808: JavaRuntimeURLConnection should only connect to non-directory resources [v3]

Alan Bateman alanb at openjdk.org
Sat Jun 21 08:58:29 UTC 2025


On Wed, 18 Jun 2025 12:55:49 GMT, David Beaumont <duke at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback changes and renaming field to match nomenclature of JEP 220.
>
> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java line 56:
> 
>> 54: 
>> 55:     // the Resource when connected
>> 56:     private volatile Resource resource;
> 
> The Resource API was never needed here and adds uncalled methods such as `getURL()` which are then implemented with code that could never be invoked.

I suspect it was needed when the protocol handler was initially created. It should have probably been cleaned up before it was brought to main line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25871#discussion_r2159982448


More information about the net-dev mailing list