RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

Jaikiran Pai jpai at openjdk.org
Wed Jun 25 07:41:43 UTC 2025


On Tue, 10 Jun 2025 22:16:18 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 499 commits:
>> 
>>  - merge latest changes from master branch
>>  - http3: improve H3ConnectionPoolTest.java
>>  - Fix snippet
>>  - Improve key destruction
>>  - merge latest changes from master branch
>>  - http3: fix bug introduced by Http3ConnectionPool and improved debug logs
>>  - http3: refactor HTTP/3 connection pool management in a separate class
>>  - Ignore DestroyFailedExceptions
>>  - Remove outdated TODO
>>  - Remove outdated TODO
>>  - ... and 489 more: https://git.openjdk.org/jdk/compare/65fda5c0...a5a0c7f8
>
> src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 164:
> 
>> 162:      */
>> 163:     static AlgorithmConstraints forQUIC(QuicTLSEngine engine,
>> 164:                                         boolean applyCertPathAlgConstraints) {
> 
> This parameter should be called `withDefaultCertPathConstraints` for consistency with other methods.

Done. The change will be available in the next refresh of this PR.

> src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 188:
> 
>> 186:     static AlgorithmConstraints forQUIC(QuicTLSEngine engine,
>> 187:                                         String[] supportedAlgorithms,
>> 188:                                         boolean applyCertPathAlgConstraints) {
> 
> Same as above:  should be called `withDefaultCertPathConstraints`

Done. The change will be available in the next refresh of this PR.

> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 243:
> 
>> 241:         }
>> 242:         // QUIC TLS version is mandated to be always TLSv1.3
>> 243:         if (!ProtocolVersion.useTLS12PlusSpec(session.getProtocol())) {
> 
> Should be `useTLS13PlusSpec`

Done. The change will be available in the next refresh of this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166022943
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166022795
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166023188


More information about the net-dev mailing list